[BP-1.17][FLINK-32751][collect] Fixes race condition between close and request handling processes in CollectSinkOperatorCoordinator #23321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e checks The version and offset check is not really necessary for the server-side processing because it's verifying test code (the ServerThread handles the forwarding of the version and the setting of the offset). Therefore, we can also remove those checks.
XComp
changed the title
XComp
changed the title
Collaborator
…improve its testability Additionally, a few new test scenarios were added to CollectSinkOperatorCoordinatorTest and SocketConnection was introduced
…t properly cancelled
XComp
force-pushed
the
FLINK-32751-v2-1.17
branch
from
455fba1 to
84309f4
Compare
Contributor
Author
|
Force-pushed fix for compilation error: |
Contributor
Author
|
The conflict resolution was a minor change. The parent PR is approved and CI is green. I'm gonna merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.17 backport for parent PR #23296