Skip to content

[FLINK-33063][table-runtime] Fix udaf with complex user defined pojo object throw error while generate record equaliser#23374

Merged
wuchong merged 1 commit intoapache:masterfrom
swuferhong:FLINK-33063
Sep 9, 2023
Merged

[FLINK-33063][table-runtime] Fix udaf with complex user defined pojo object throw error while generate record equaliser#23374
wuchong merged 1 commit intoapache:masterfrom
swuferhong:FLINK-33063

Conversation

@swuferhong
Copy link
Copy Markdown
Contributor

What is the purpose of the change

When user create an udaf while recore contains user define complex pojo object (like List or Map). The codegen will throw error while generating record equaliser, the error is:
A method named "compareTo" is not declared in any enclosing class nor any subtype, nor through a static import.

Brief change log

  • Add a test to cover the user defined pojo object.

Verifying this change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no docs

@swuferhong swuferhong changed the title [FLINK-33063][table-planner] Fix udaf with complex user defined pojo object throw error while generate record equaliser [FLINK-33063][table-runtime] Fix udaf with complex user defined pojo object throw error while generate record equaliser Sep 8, 2023
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Sep 8, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…object throw error while generate record equaliser
Copy link
Copy Markdown
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 01cb6ef into apache:master Sep 9, 2023
@wuchong
Copy link
Copy Markdown
Member

wuchong commented Sep 9, 2023

@swuferhong could you open a cherry-pick pull request for release-1.18 branch?

@swuferhong
Copy link
Copy Markdown
Contributor Author

@swuferhong could you open a cherry-pick pull request for release-1.18 branch?

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants