Skip to content

Conversation

@m8719-github
Copy link

@m8719-github m8719-github commented Oct 14, 2023

What is the purpose of the change

Apache Avro 1.11.3 contains an important fix: AVRO-3536
Just want to make sure it makes it into the next Flink release.

Brief change log

Bumped up Apache Avro version to 1.11.3

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@m8719-github m8719-github changed the title Bump avro [AVRO-3536] [flink-avro] Union type not inheriting type conversions Oct 14, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 14, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@afedulov
Copy link
Contributor

afedulov commented Oct 16, 2023

@m8719-github thanks for the contribution. All Flink PRs need to have a corresponding issue in Flink JIRA. Could you please create one with a description of the issue being addressed?
https://issues.apache.org/jira/projects/FLINK/issues/

+ " {\"name\": \"name\", \"type\": \"string\"}"
+ " ]\n"
+ "}]");
+ "}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is parsing more strict in the newer version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, looks like it.

@afedulov
Copy link
Contributor

afedulov commented Oct 16, 2023

Actually, there is already an earlier PR with this bump to address vulnerabilities:
#23508

@m8719-github
Copy link
Author

m8719-github commented Oct 16, 2023

I've reached out to Martijn here: FLINK-33238 to see if we can consolidate.

@m8719-github m8719-github changed the title [AVRO-3536] [flink-avro] Union type not inheriting type conversions [FLINK-33303] [flink-avro] Union type not inheriting type conversions Oct 18, 2023
@m8719-github
Copy link
Author

m8719-github commented Oct 18, 2023

@afedulov Created FLINK-33303
Do you think there is still time to get this into Flink 1.18 ?

@afedulov
Copy link
Contributor

afedulov commented Oct 18, 2023

Do you think there is still time to get this into Flink 1.18 ?

Not unless it fixes some critical vulnerability or test regression. 1.18 was supposed to be released end of September, so I am afraid we are way past the features integration timeframe.
https://cwiki.apache.org/confluence/display/FLINK/1.18+Release

@MartijnVisser
Copy link
Contributor

Fixed by #23508 - Will be backported to 1.18 (so for 1.18.1) with #23559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants