[FLINK-33291][build] Sets the enforced range for Maven and JDK within the release profile#23529
Merged
XComp merged 1 commit intoapache:masterfrom Oct 20, 2023
Merged
[FLINK-33291][build] Sets the enforced range for Maven and JDK within the release profile#23529XComp merged 1 commit intoapache:masterfrom
XComp merged 1 commit intoapache:masterfrom
Conversation
Collaborator
snuyanzin
reviewed
Oct 17, 2023
snuyanzin
approved these changes
Oct 17, 2023
Contributor
snuyanzin
left a comment
There was a problem hiding this comment.
I checked locally that it works
… the release profile
Contributor
Author
|
Thanks for the approval. I did a slight adjustment to the comment after confirming with Chesnay. I will go ahead and create backports. |
This was referenced Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
We want to enforce the Maven and JDK version for releases based on the versions that are used in Flink's CI pipeline to ensure a certain level of quality control.
Brief change log
${target.java.version}or[1.8]to cover any minor releasesVerifying this change
Manual verification by running
./mvn -pl flink-annotations -DskipTests -Prelease validatewith different Java and Maven versionsDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation