Skip to content

[FLINK-33291][build] Sets the enforced range for Maven and JDK within the release profile#23529

Merged
XComp merged 1 commit intoapache:masterfrom
XComp:FLINK-33291
Oct 20, 2023
Merged

[FLINK-33291][build] Sets the enforced range for Maven and JDK within the release profile#23529
XComp merged 1 commit intoapache:masterfrom
XComp:FLINK-33291

Conversation

@XComp
Copy link
Copy Markdown
Contributor

@XComp XComp commented Oct 17, 2023

What is the purpose of the change

We want to enforce the Maven and JDK version for releases based on the versions that are used in Flink's CI pipeline to ensure a certain level of quality control.

Brief change log

  • Adds proper range for Maven and JDK
  • For the JDK version, it looks like we cannot use ${target.java.version} or [1.8] to cover any minor releases

Verifying this change

Manual verification by running ./mvn -pl flink-annotations -DskipTests -Prelease validate with different Java and Maven versions

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@XComp XComp requested a review from zentol October 17, 2023 13:40
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Oct 17, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked locally that it works

@XComp XComp removed the request for review from zentol October 18, 2023 06:21
@XComp
Copy link
Copy Markdown
Contributor Author

XComp commented Oct 18, 2023

Thanks for the approval. I did a slight adjustment to the comment after confirming with Chesnay. I will go ahead and create backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants