Skip to content

Conversation

@dyccode
Copy link
Contributor

@dyccode dyccode commented Nov 6, 2023

What is the purpose of the change

This pull request clears the legacy state of Sinkv2.

Brief change log

SinkV2 clears legacy states after initialization.

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dyccode
Copy link
Contributor Author

dyccode commented Nov 6, 2023

@flinkbot run azure

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 6, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dyccode
Copy link
Contributor Author

dyccode commented Nov 6, 2023

@flinkbot run azure

Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I just thinked whether it could be tested easily.
Since it's related to the migration of Kafka Sink, Do you have any other comments?
@PatrickRen

@dyccode
Copy link
Contributor Author

dyccode commented Nov 23, 2023

@masteryhx Thanks for the review.What I need to do to merge this pr? Looking forward to your reply.

Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
The PR is fine. I will merge it.

@masteryhx
Copy link
Contributor

merged efbd8c4 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants