Skip to content

Conversation

@Jiabao-Sun
Copy link
Contributor

What is the purpose of the change

[FLINK-33551] Fix HiveTemporalJoinITCase.testProcTimeTemporalJoinHiveTable nightly CI fails

Brief change log

During the migration of Junit5, some of the remaining codes were not deleted, resulting in the problem.

https://github.com/apache/flink/pull/23349/files#diff-1e88862e59ad54f8c596e5e56f126fec6a09768bee986c9547d14d2add1e048bR109-R112

Verifying this change

mvn test -Phadoop3-tests,hive3 -Dflink.hadoop.version=3.2.3 -Dtest=org.apache.flink.connectors.hive.HiveTemporalJoinITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 16, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for fixing the issue that quickly. :-)

@XComp XComp merged commit b2b3152 into apache:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants