Skip to content

[FLINK-33578][ci] Removes scala-2.12 system property#23738

Merged
XComp merged 1 commit intoapache:masterfrom
XComp:FLINK-33578
Nov 17, 2023
Merged

[FLINK-33578][ci] Removes scala-2.12 system property#23738
XComp merged 1 commit intoapache:masterfrom
XComp:FLINK-33578

Conversation

@XComp
Copy link
Copy Markdown
Contributor

@XComp XComp commented Nov 17, 2023

What is the purpose of the change

We're only relying on Scala 2.12 (and the plan is to drop it entirely for 2.x). The Scala prefix is still present in CI, though. This commit cleans it up entirely.

This clean up step helps reduce the noise in the GHA workflow change (FLINK-27075). There's no need to label workflows with the scala version. Therefore, we can remove the scala version from the build parameters entirely.

Brief change log

  • Removed scala-2.12 system variable from release scripts and azure workflow

Verifying this change

  • The nightly deployment should still look the same (related to the tools/releasing/deploy_staging_jars.sh change)
  • The binary release artifacts shouldn't have changed (related to the tools/releasing/create_binary_release.sh change)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

We're only relying on Scala 2.12 (and the plan is to drop it entirely for 2.x). The Scala prefix is still present in CI, though. This commit cleans it up entirely. This clean up step helps reduce the noise in the GHA workflow change (FLINK-27075)
@XComp XComp requested a review from MartijnVisser November 17, 2023 05:52
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Nov 17, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % CI passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants