[#FLINK-33596][Connectors/Hive]] Fold expression before transfer function to RexNode.#23759
Closed
yunfan123 wants to merge 1 commit intoapache:masterfrom
Closed
[#FLINK-33596][Connectors/Hive]] Fold expression before transfer function to RexNode.#23759yunfan123 wants to merge 1 commit intoapache:masterfrom
yunfan123 wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
f4f8a99 to
a76a034
Compare
Contributor
Author
|
It has replaced by apache/flink-connector-hive#15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fold expression before transfer function to RexNode.
Hive will fold expression in optimization stage.
But flink-hive-parser use flink optimization.
And flink can't know some hive function can be constant value.
Some hive code reference:
https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java#L62
https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1776
https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1069
Brief change log
Try to transfer to constant before function transfer to rexNode.
Verifying this change
This change is verified by added test
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation