[FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released#23863
Merged
reswqa merged 1 commit intoapache:masterfrom Dec 6, 2023
Conversation
Collaborator
5f07572 to
50f3828
Compare
Contributor
Author
|
If you have some free time, could you please take a look? Thank you 😊 @reswqa |
reswqa
reviewed
Dec 5, 2023
Member
reswqa
left a comment
There was a problem hiding this comment.
Thanks @WencongLiu for the fix, I left some comments, PTAL.
...apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java
Outdated
Show resolved
Hide resolved
...apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskTierProducerAgent.java
Outdated
Show resolved
Hide resolved
50f3828 to
4da5c02
Compare
reswqa
approved these changes
Dec 6, 2023
Member
reswqa
left a comment
There was a problem hiding this comment.
Thanks for the update, I'm + 1 for this one. Could you please also align commit message with the title of this PR.
…dexOfFirstBufferInSegment from throwing NPE when the task is released
4da5c02 to
2b15892
Compare
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation