Skip to content

[FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released#23863

Merged
reswqa merged 1 commit intoapache:masterfrom
WencongLiu:dev_FLINK-33502_2
Dec 6, 2023
Merged

Conversation

@WencongLiu
Copy link
Copy Markdown
Contributor

@WencongLiu WencongLiu commented Dec 4, 2023

What is the purpose of the change

Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Dec 4, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@WencongLiu
Copy link
Copy Markdown
Contributor Author

If you have some free time, could you please take a look? Thank you 😊 @reswqa

@WencongLiu WencongLiu changed the title [FLINK-33502][network] Make DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment return null when the task is released [FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released Dec 5, 2023
Copy link
Copy Markdown
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WencongLiu for the fix, I left some comments, PTAL.

Copy link
Copy Markdown
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I'm + 1 for this one. Could you please also align commit message with the title of this PR.

…dexOfFirstBufferInSegment from throwing NPE when the task is released
@WencongLiu
Copy link
Copy Markdown
Contributor Author

Thanks for the update, I'm + 1 for this one. Could you please also align commit message with the title of this PR.

Done.

@reswqa reswqa merged commit 6db32a3 into apache:master Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants