[FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase#23952
Merged
leonardBang merged 1 commit intoapache:masterfrom Dec 19, 2023
Merged
Conversation
…ethod in TableTestBase
Contributor
Author
|
Hi @leonardBang, please help review it when you have time. |
Collaborator
Contributor
Author
|
@flinkbot run azure |
leonardBang
approved these changes
Dec 19, 2023
Contributor
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @Jiabao-Sun for the contribution, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase
Brief change log
After completing the JUnit5 migration in the table planner, there is an incompatibility issue with JUnit TestName and TestInfo. Therefore, considering introducing the methodName method in TableTestBase. External connectors's TablePlanTest can override this method when performing JUnit 5 migration for TableTestBase to avoid compilation issues.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation