Skip to content

[FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase#23952

Merged
leonardBang merged 1 commit intoapache:masterfrom
Jiabao-Sun:FLINK-33876
Dec 19, 2023
Merged

[FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase#23952
leonardBang merged 1 commit intoapache:masterfrom
Jiabao-Sun:FLINK-33876

Conversation

@Jiabao-Sun
Copy link
Copy Markdown
Contributor

What is the purpose of the change

[FLINK-33876][table-planner][JUnit5 Migration] Introduce methodName method in TableTestBase

Brief change log

After completing the JUnit5 migration in the table planner, there is an incompatibility issue with JUnit TestName and TestInfo. Therefore, considering introducing the methodName method in TableTestBase. External connectors's TablePlanTest can override this method when performing JUnit 5 migration for TableTestBase to avoid compilation issues.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@Jiabao-Sun
Copy link
Copy Markdown
Contributor Author

Hi @leonardBang, please help review it when you have time.

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Dec 18, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@leonardBang leonardBang self-requested a review December 18, 2023 16:19
@Jiabao-Sun
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiabao-Sun for the contribution, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants