-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-33879] Avoids the potential hang of Hybrid Shuffle during redistribution #23957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0553ee to
faaf085
Compare
faaf085 to
04efba4
Compare
|
@TanYuxin-tyx Could you help review this PR? |
TanYuxin-tyx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiangxin369 Thanks for the contribution. I have some comments on the PR, PTAL.
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Outdated
Show resolved
Hide resolved
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Show resolved
Hide resolved
...apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemorySpec.java
Outdated
Show resolved
Hide resolved
9464871 to
c3001a0
Compare
|
@xintongsong Could you take a look at this PR? |
c3001a0 to
abe635e
Compare
TanYuxin-tyx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiangxin369 Thanks for the update, I have no more comments on the change.
...apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemorySpec.java
Outdated
Show resolved
Hide resolved
...he/flink/runtime/io/network/partition/hybrid/tiered/tier/memory/MemoryTierProducerAgent.java
Outdated
Show resolved
Hide resolved
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Show resolved
Hide resolved
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Outdated
Show resolved
Hide resolved
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Outdated
Show resolved
Hide resolved
...ache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartitionTest.java
Show resolved
Hide resolved
abe635e to
a61a43c
Compare
reswqa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, I left some comments.
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Show resolved
Hide resolved
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Show resolved
Hide resolved
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Outdated
Show resolved
Hide resolved
...k/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImplTest.java
Show resolved
Hide resolved
...ache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartitionTest.java
Show resolved
Hide resolved
...ache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartitionTest.java
Show resolved
Hide resolved
...ache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartitionTest.java
Show resolved
Hide resolved
a61a43c to
bfbd378
Compare
reswqa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, I have left some comments, please take a look.
...g/apache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartition.java
Show resolved
Hide resolved
...ache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartitionTest.java
Outdated
Show resolved
Hide resolved
|
@reswqa Thanks for the review, I've updated the PR, please take a look. |
...flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java
Outdated
Show resolved
Hide resolved
reswqa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiangxin369 Thanks for the quick update, this PR LGTM now.
965193f to
227a2e2
Compare
|
@reswqa Seems that the CI failed but the cause is related to python rather than this PR. Could you help merge it? |
227a2e2 to
3556bc6
Compare
What is the purpose of the change
This PR is to avoid the potential hang of Hybrid Shuffle during redistribution. The details about how a hang happens, please see issue.
Brief change log
ensureCapacityto TieredStorageMemoryManager to help reserve enough buffers.definitelyRecycledto indicate that the buffers of a tier can be definitely recycled even if there are no readers.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation