Skip to content

Conversation

@jiangxin369
Copy link
Contributor

What is the purpose of the change

Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot.

Brief change log

  • Disable the resource requirements to make sure the job failed to acquire slots until timeout.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable )

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 21, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@jiangxin369 jiangxin369 changed the title [Flink-33414] Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot [FLINK-33414] Fix the unstable test MiniClusterITCase.testHandleStreamingJobsWhenNotEnoughSlot Dec 21, 2023
@jiangxin369
Copy link
Contributor Author

jiangxin369 commented Dec 23, 2023

@XComp Could you help review this PR when you are free?

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jiangxin369 for your efforts. I found the time to look into the issue. Your change looks reasonable. I have one question, though. PTAL.

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'm gonna go ahead and merge it after CI turned green.

@XComp
Copy link
Contributor

XComp commented Jan 8, 2024

The test failure is unrelated to this change (because it's python). I'm gonna go ahead and merge this PR.

@XComp XComp merged commit f45de0c into apache:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants