[FLINK-33941][table-planner] use field index instead of field name about window time column#23991
Merged
LadyForest merged 2 commits intoapache:masterfrom Jan 4, 2024
Merged
Conversation
Collaborator
LadyForest
reviewed
Jan 3, 2024
Contributor
LadyForest
left a comment
There was a problem hiding this comment.
Hi @xuyangzhong, thanks for the contribution! The PR looks good and I just left one minor comment.
...k-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala
Outdated
Show resolved
Hide resolved
LadyForest
reviewed
Jan 3, 2024
...n/java/org/apache/flink/table/planner/plan/rules/logical/FlinkAggregateProjectMergeRule.java
Show resolved
Hide resolved
…out window time column
35919f7 to
5a16e0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In some exec nodes like StreamExecGroupWindowAggregate and some rules like BatchPhysicalWindowAggregateRule, planner uses "AggregateUtil#timeFieldIndex" to access the actual time field index, instead of using the time field index in LogicalWindow#timeAttribute directly. However, it would be more formal to use the field index instead of the column field.
Brief change log
Verifying this change
All existent tests can cover this fix.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation