Skip to content

Conversation

@bvarghese1
Copy link
Contributor

What is the purpose of the change

Add restore tests for MiniBatchAssigner node

Verifying this change

This change added tests and can be verified as follows:

  • Added restore tests for MiniBatchAssigner node which verifies the generated compiled plan with the saved compiled plan.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@bvarghese1 bvarghese1 force-pushed the mini_batch_assigner_restore_tests branch from 22f6cc8 to a671536 Compare January 5, 2024 19:50
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 5, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@bvarghese1
Copy link
Contributor Author

@flinkbot run azure

@bvarghese1 bvarghese1 force-pushed the mini_batch_assigner_restore_tests branch from a671536 to 3b7ff3c Compare January 10, 2024 02:21
@bvarghese1 bvarghese1 force-pushed the mini_batch_assigner_restore_tests branch from 3b7ff3c to 9bc95a4 Compare January 10, 2024 17:03
Copy link
Contributor

@dawidwys dawidwys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dawidwys dawidwys merged commit 881062f into apache:master Jan 11, 2024
@bvarghese1 bvarghese1 deleted the mini_batch_assigner_restore_tests branch January 11, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants