[FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy #24040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
1996fanrui
commented
Jan 8, 2024
Member
Author
1996fanrui
left a comment
1996fanrui
left a comment
There was a problem hiding this comment.
Hi @zhuzhurk @RocMarshal @qinf , would you mind helping take a look this PR in your free time? Thanks~
flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java
Outdated
Show resolved
Hide resolved
…default restart strategy
1996fanrui
force-pushed
the
33738/default-restart-strategy
branch
from
5670a48 to
864e0b0
Compare
Contributor
|
Thank you @1996fanrui for your contribution, LGTM. |
qinf
approved these changes
Jan 9, 2024
1996fanrui
force-pushed
the
33738/default-restart-strategy
branch
from
864e0b0 to
c9b515a
Compare
RocMarshal
approved these changes
Jan 10, 2024
Contributor
RocMarshal
left a comment
RocMarshal
left a comment
There was a problem hiding this comment.
Thanks for the contribution~
LGTM +1. :)
Member
Author
|
Thanks to everyone for the review! The CI is green for now, merging~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy