Skip to content

Conversation

@XComp
Copy link
Contributor

@XComp XComp commented Jan 12, 2024

What is the purpose of the change

See FLINK-34070 for more context on this change.

Brief change log

  • Adds dedicated test for no-resource-available handling through timeout
  • Adds dedicated test for no-resource-available handling a request from the ResourceManager (and disabled it for the AdaptiveScheduler since it's not supported)

Verifying this change

  • Two CI runs with DefaultScheduler and AdaptiveScheduler enabled

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 12, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…narios where there are not enough slots available.
Copy link
Contributor

@jiangxin369 jiangxin369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XComp Thanks for the PR, LGTM overall, just some minor comments. Please take a look.

Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @XComp
and thanks for the review @jiangxin369
also lgtm from my side

@XComp
Copy link
Contributor Author

XComp commented Jan 17, 2024

Thanks for the review @jiangxin369 and for the approval @snuyanzin . I'm gonna merge this one. The failure is caused by FLINK-34077 and, therefore, unrelated. I verified that the one test is disabled locally. 👍

@XComp XComp merged commit 024ed96 into apache:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants