Skip to content

Conversation

@vahmed-hamdy
Copy link
Contributor

What is the purpose of the change

  • Disabling intermittently failing test due to high frequency of failures.

Brief change log

  • Added Disabled annotation to AsyncSinkWriterThrottlingTest

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 23, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@vahmed-hamdy vahmed-hamdy force-pushed the flink-31472-asyncsink-throttling-test branch from 5e2429d to ea54e35 Compare January 30, 2024 09:26
@vahmed-hamdy vahmed-hamdy requested a review from XComp January 30, 2024 09:27
@vahmed-hamdy
Copy link
Contributor Author

@XComp I have addressed your comments, the pipeline is ironically failing for another unstable test

@XComp
Copy link
Contributor

XComp commented Jan 30, 2024

@XComp I have addressed your comments, the pipeline is ironically failing for another unstable test

The CI pipeline is not failing because of an unstable test. It's failing because your PR is based on a version where master was unfortunately broken due to some compilation error. Rebasing the branch should fix the issue.

@vahmed-hamdy vahmed-hamdy force-pushed the flink-31472-asyncsink-throttling-test branch from ea54e35 to bbafe8b Compare January 31, 2024 13:58
@vahmed-hamdy
Copy link
Contributor Author

@flinkbot run azure

@vahmed-hamdy vahmed-hamdy force-pushed the flink-31472-asyncsink-throttling-test branch from bbafe8b to f02ebaa Compare February 1, 2024 13:54
@XComp
Copy link
Contributor

XComp commented Mar 11, 2024

According to this comment in FLINK-31472 we're gonna go ahead trying to fix the issue without disabling the test for now. I'm gonna close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants