Skip to content

Conversation

@SinBex
Copy link
Contributor

@SinBex SinBex commented Jan 26, 2024

What is the purpose of the change

  • In order not to block the CI, we should to temporarily disable CacheITCase#testRetryOnCorruptedClusterDataset, and it will be fixed in 1.19 test phase.*

Brief change log

(for example:)

  • Temporarily disable CacheITCase#testRetryOnCorruptedClusterDataset

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no /)
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( no)

@SinBex SinBex force-pushed the fix_cache_it_case_adaptive_batch branch from fbc5f51 to 3019390 Compare January 26, 2024 11:31
@SinBex SinBex force-pushed the fix_cache_it_case_adaptive_batch branch from 3019390 to 0f0dc28 Compare January 26, 2024 11:32
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Merging it now because the change is simple enough and to unblock other CIs earlier.

@flinkbot
Copy link
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zhuzhurk zhuzhurk closed this in 05ee359 Jan 26, 2024
snuyanzin pushed a commit to snuyanzin/flink that referenced this pull request Jan 27, 2024
snuyanzin pushed a commit to snuyanzin/flink that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants