Skip to content

Conversation

@xuyangzhong
Copy link
Contributor

What is the purpose of the change

This pr to fix unclear exception without setting minibatch size when using minibatch join or agg.

The main change is to revert the exception thrown while checking illegal minibatch-size in pr https://github.com/apache/flink/pull/24161/files .

image

Brief change log

  • Revert the logic to throw exception when meet negative minibatch size
  • Add tests for minibatch join and minibatch agg

Verifying this change

Tests are added to verify it.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

…nibatch size when using minibatch join or agg
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 4, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@xishuaidelin xishuaidelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lsyldliu lsyldliu closed this in de2d175 Feb 5, 2024
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for forget approve, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants