[FLINK-34481][table] Migrate SetOpRewriteUtil to java#24358
Merged
JingGe merged 1 commit intoapache:masterfrom Mar 1, 2024
Merged
[FLINK-34481][table] Migrate SetOpRewriteUtil to java#24358JingGe merged 1 commit intoapache:masterfrom
JingGe merged 1 commit intoapache:masterfrom
Conversation
Collaborator
70da561 to
6f8e78b
Compare
JingGe
reviewed
Feb 21, 2024
| import java.util.Set; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| /** Util class that rewrite [[SetOp]]. */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Util class that rewrite [[SetOp]]. */ | |
| /** Util class that rewrite {@link org.apache.calcite.rel.core.SetOp}. */ |
Contributor
Author
There was a problem hiding this comment.
done @JingGe ,thanks for your review very much
Contributor
Author
|
hi @JingGe will you review it again? |
JingGe
reviewed
Feb 27, 2024
...ala/org/apache/flink/table/planner/plan/rules/logical/ReplaceIntersectWithSemiJoinRule.scala
Outdated
Show resolved
Hide resolved
...-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/SetOpRewriteUtil.java
Outdated
Show resolved
Hide resolved
ca8f158 to
01b9176
Compare
Contributor
|
@liuyongvs Thanks for your effort. Would you please to squash the commits? |
01b9176 to
c663142
Compare
c663142 to
19fa98b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR migrates SetOpRewriteUtil to java for migrating
ReplaceMinusWithAntiJoinRule
ReplaceMinusWithAntiJoinRule
RewriteIntersectAllRule
RewriteMinusAllRule
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation