Skip to content

[FLINK-34481][table] Migrate SetOpRewriteUtil to java#24358

Merged
JingGe merged 1 commit intoapache:masterfrom
liuyongvs:ReplaceMinusWithAntiJoinRule
Mar 1, 2024
Merged

[FLINK-34481][table] Migrate SetOpRewriteUtil to java#24358
JingGe merged 1 commit intoapache:masterfrom
liuyongvs:ReplaceMinusWithAntiJoinRule

Conversation

@liuyongvs
Copy link
Copy Markdown
Contributor

What is the purpose of the change

The PR migrates SetOpRewriteUtil to java for migrating
ReplaceMinusWithAntiJoinRule
ReplaceMinusWithAntiJoinRule
RewriteIntersectAllRule
RewriteMinusAllRule

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Feb 21, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs liuyongvs force-pushed the ReplaceMinusWithAntiJoinRule branch from 70da561 to 6f8e78b Compare February 21, 2024 12:11
import java.util.Set;
import java.util.stream.Collectors;

/** Util class that rewrite [[SetOp]]. */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Util class that rewrite [[SetOp]]. */
/** Util class that rewrite {@link org.apache.calcite.rel.core.SetOp}. */

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @JingGe ,thanks for your review very much

@liuyongvs liuyongvs requested a review from JingGe February 22, 2024 01:52
@liuyongvs
Copy link
Copy Markdown
Contributor Author

hi @JingGe will you review it again?

@liuyongvs liuyongvs requested a review from JingGe February 28, 2024 02:18
@liuyongvs liuyongvs force-pushed the ReplaceMinusWithAntiJoinRule branch from ca8f158 to 01b9176 Compare February 28, 2024 06:39
Copy link
Copy Markdown
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JingGe
Copy link
Copy Markdown
Contributor

JingGe commented Feb 29, 2024

@liuyongvs Thanks for your effort. Would you please to squash the commits?

@liuyongvs liuyongvs force-pushed the ReplaceMinusWithAntiJoinRule branch from 01b9176 to c663142 Compare February 29, 2024 12:15
@liuyongvs liuyongvs force-pushed the ReplaceMinusWithAntiJoinRule branch from c663142 to 19fa98b Compare February 29, 2024 12:18
@JingGe JingGe merged commit f523b9d into apache:master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants