Skip to content

[hotfix] A couple of hotfixes related to e2e tests#24472

Merged
pnowojski merged 3 commits intoapache:masterfrom
pnowojski:hotfix
Mar 11, 2024
Merged

[hotfix] A couple of hotfixes related to e2e tests#24472
pnowojski merged 3 commits intoapache:masterfrom
pnowojski:hotfix

Conversation

@pnowojski
Copy link
Copy Markdown
Contributor

@pnowojski pnowojski commented Mar 8, 2024

What is the purpose of the change

Fixing a couple of smaller issues.

Brief change log

Please check individual commit messages.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

pnowojski added 3 commits March 8, 2024 16:18
@pnowojski
[hotfix][e2e] Fix naming of MAX_NUM_METRICS
f400456
@pnowojski
[hotfix][e2e] Fix wait_oper_metric_num_in_records
3026785 
Previously any test using wait_oper_metric_num_in_records twice
was invalid, as second call would always set OLD_NUM_METRICS = 0
causing the second call to track the same logs as the first one.
For example even if the second run was in a restart loop and didn't
process any records, the second call would process the logs from
the first run as claim that everything succeded.
@pnowojski
[hotfix] Add toString to StateHandleDownloadSpec
1715f47
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Mar 8, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@pnowojski pnowojski merged commit 2ec2a60 into apache:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkhachatryan rkhachatryan rkhachatryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pnowojski @flinkbot @rkhachatryan