-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-32079][checkpoint] Support to read/write checkpoint metadata of merged files #24480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@masteryhx |
Thanks for the suggestion. |
Zakelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Minor question:
| dos.writeLong(relativeFileStateHandle.getStateSize()); | ||
| } else if (stateHandle instanceof SegmentFileStateHandle) { | ||
| if (stateHandle instanceof EmptySegmentFileStateHandle) { | ||
| dos.writeByte(EMPTY_SEGMENT_FILE_HANDLE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, there is not a chance that EmptySegmentFileStateHandle is serialized here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This serializeStreamStateHandle is used when serialize EmptyFileMergingOperatorStreamStateHandle which holds this as its delegated empty stream state handle.
So it's still needed, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.... I missed the serializeStreamStateHandle(stateHandle.getDelegateStateHandle(), dos); part
Zakelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! LGTM+1
What is the purpose of the change
Support to read/write checkpoint metadata of merged files
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation