Skip to content

Conversation

@RyanSkraba
Copy link
Contributor

What is the purpose of the change

There's a missing brace in the root pom.xml that would ignore any tests that should be excluded on a specific JDK version (FailsOnJavaXxx) when the enable-adaptive-scheduler profile is enabled. There currently aren't any, but this should be corrected (and maybe backported)?

Brief change log

Add the missing brace.

Verifying this change

This change is a trivial rework without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, thanks for noticing.

@XComp XComp merged commit cb1d68e into apache:master Mar 20, 2024
@RyanSkraba RyanSkraba deleted the rskraba/hotfix-pom-typo branch March 20, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants