Skip to content

Conversation

@1996fanrui
Copy link
Member

What is the purpose of the change

The performance of serializerHeavyString regresses since April 3, and had not yet recovered on April 8th.

After running a series of benchmarks, I found FLINK-34955 causes the performance regression.

FLINK-34955 wants to fix CVE issues of common-compress, but it upgrades the commons-io together. I try to revert commons-io to 2.11.0, and the performance is recovered.

Brief change log

  • [FLINK-35040] Revert commons-io to 2.11.0
    • Revert part of [FLINK-34955] Upgrade commons-compress to 1.26.0. (#24580)

Revert part of `[FLINK-34955] Upgrade commons-compress to 1.26.0. (apache#24580)`
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 11, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@slfan1989
Copy link
Contributor

slfan1989 commented Apr 11, 2024

@1996fanrui If we confirm that it's an issue with commons-io, couldn't we resolve it by upgrading commons-io instead? The reason for upgrading commons-io is that common-compress requires a higher version.

@1996fanrui
Copy link
Member Author

1996fanrui commented Apr 11, 2024

Thanks @slfan1989 for the quick review!

@1996fanrui If we confirm that it's an issue with commons-io, couldn't we resolve it by upgrading commons-io instead?

Do you mean upgrading commons-io to the latest version? If yes, I tried upgrading commons-io to 2.16.1, the performance is still not good.

I saw 2.16.1 is the latest version of commons-io[1].

[1] https://mvnrepository.com/artifact/commons-io/commons-io

@slfan1989
Copy link
Contributor

Thanks @slfan1989 for the quick review!

@1996fanrui If we confirm that it's an issue with commons-io, couldn't we resolve it by upgrading commons-io instead?

Do you mean upgrading commons-io to the latest version? If yes, I tried upgrading commons-io to 2.16.1, it doesn't work.

I saw 2.16.1 is the latest version of commons-io[1].

[1] https://mvnrepository.com/artifact/commons-io/commons-io

I'm sorry for any inconvenience caused. The reason for upgrading commons-io is that common-compress requires a higher version. We encounter a "class not found" issue when using commons-io 2.11. If we can't meet the performance requirements, I think we might have to revert FLINK-34955.

@1996fanrui
Copy link
Member Author

It seems reverting it doesn't make sense, I close this PR first.

@1996fanrui 1996fanrui closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants