Skip to content

Conversation

@zoltar9264
Copy link
Contributor

What is the purpose of the change

As title said, normalize ForSt option names and working dir.

Brief change log

  • rename option "state.backend.forst.localdir" to "state.backend.forst.local-dir"
  • rename option "state.backend.forst.remotedir" to "state.backend.forst.remote-dir"
  • fix the forst backend working dir mistake

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

Please help review this change @masteryhx , thanks.

@flinkbot
Copy link
Collaborator

flinkbot commented May 28, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
PTAL my comments.

Co-authored-by: yhx <masteryhx@gmail.com>
Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
LGTM.

@masteryhx masteryhx closed this May 29, 2024
@zoltar9264 zoltar9264 deleted the hotfix-forst-dir branch May 29, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants