Skip to content

[FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging#24924

Closed
Zakelly wants to merge 1 commit intoapache:masterfrom
Zakelly:f35570
Closed

[FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging#24924
Zakelly wants to merge 1 commit intoapache:masterfrom
Zakelly:f35570

Conversation

@Zakelly
Copy link
Copy Markdown
Contributor

@Zakelly Zakelly commented Jun 12, 2024

What is the purpose of the change

In checkpoint file merging, we should take PlaceholderStreamStateHandle into account during lifecycle, since it can be a file merged one.

Brief change log

  • take PlaceholderStreamStateHandle into account in reusePreviousStateHandle and couldReuseStateHandle

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jun 12, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@fredia fredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, overall LGTM, It would be better if there were more reproducible tests.

for (KeyedStateHandle keyedStateHandle : keyedStateHandles) {
Assertions.assertInstanceOf(
IncrementalRemoteKeyedStateHandle.class, keyedStateHandle);
assertThat(keyedStateHandle)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this bug can be reproduced if we perform several checkpoints before restoring to generate placeholder handle, would you like to change this ITCase to make it easier to reproduce?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to 4 checkpoints per round

@Zakelly
Copy link
Copy Markdown
Contributor Author

Zakelly commented Jun 12, 2024

@flinkbot run azure

@Zakelly Zakelly closed this in fb5fd48 Jun 12, 2024
@Zakelly Zakelly deleted the f35570 branch June 12, 2024 13:21
superdiaodiao pushed a commit to superdiaodiao/flink that referenced this pull request Jul 4, 2024
snuyanzin pushed a commit to snuyanzin/flink that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants