[FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging#24924
Closed
Zakelly wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-35570] Consider PlaceholderStreamStateHandle in checkpoint file merging#24924Zakelly wants to merge 1 commit intoapache:masterfrom
Zakelly wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
fredia
approved these changes
Jun 12, 2024
Contributor
fredia
left a comment
There was a problem hiding this comment.
Thanks for the PR, overall LGTM, It would be better if there were more reproducible tests.
| for (KeyedStateHandle keyedStateHandle : keyedStateHandles) { | ||
| Assertions.assertInstanceOf( | ||
| IncrementalRemoteKeyedStateHandle.class, keyedStateHandle); | ||
| assertThat(keyedStateHandle) |
Contributor
There was a problem hiding this comment.
IIUC, this bug can be reproduced if we perform several checkpoints before restoring to generate placeholder handle, would you like to change this ITCase to make it easier to reproduce?
Contributor
Author
There was a problem hiding this comment.
change to 4 checkpoints per round
Contributor
Author
|
@flinkbot run azure |
superdiaodiao
pushed a commit
to superdiaodiao/flink
that referenced
this pull request
Jul 4, 2024
…le merging This fixes apache#24924
snuyanzin
pushed a commit
to snuyanzin/flink
that referenced
this pull request
Jul 21, 2024
…le merging This fixes apache#24924
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In checkpoint file merging, we should take
PlaceholderStreamStateHandleinto account during lifecycle, since it can be a file merged one.Brief change log
PlaceholderStreamStateHandleinto account inreusePreviousStateHandleandcouldReuseStateHandleVerifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation