Skip to content

Conversation

@liyubin117
Copy link
Contributor

@liyubin117 liyubin117 commented Jun 14, 2024

Brief change log

  • To ensure at least one fraction of hosts to be local, it should be ia.getNumberOfLocalAssignments() as before.

Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liyubin117 for the fix!

LGTM

cc @GOODBOY008 , it's caused by #24881

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 14, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@1996fanrui 1996fanrui self-assigned this Jun 14, 2024
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008
Copy link
Member

@1996fanrui It's indeed my mistake. @liyubin117 Great catch.

@liyubin117
Copy link
Contributor Author

@1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e tests have stucked for hours, As the code is about to be frozen, could you help cancel some tasks? For example, this task has already failed but is still running the e2e test.
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=60262&view=results

@1996fanrui
Copy link
Member

@1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e tests have stucked for hours, As the code is about to be frozen, could you help cancel some tasks? For example, this task has already failed but is still running the e2e test. https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=60262&view=results

No worries, the bugfix still can be merged after feature freeze. The feature cannot be merged after feature freeze.

Let's wait for the CI for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants