-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 #24967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
anupamaggarwal
wants to merge
18
commits into
apache:master
from
anupamaggarwal:34111-jsonquote_unquote
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
42bbced
[FLINK-34111] Add support for json_quote, json_unquote, address feedb…
anupamaggarwal 24a73dc
[FLINK-34111] Removed redundant checks, update documentation to remov…
anupamaggarwal 9a60e44
[FLINK-34111] Update scala test
anupamaggarwal fd9e5a7
Merge branch 'apache-master' into 34111-jsonquote_unquote
anupamaggarwal 0056727
[FLINK-34111] Refactor, update comments
anupamaggarwal 3903d24
[FLINK-34111] Fix spotless warning
anupamaggarwal 48b570f
[FLINK-34111] Add missing function definitions, fix test
anupamaggarwal 4267018
[FLINK-34111] Fix java.util.IllegalFormatConversionException in json_…
anupamaggarwal 141c63e
[FLINK-34111] CR: Update documentation, add separate function for neg…
anupamaggarwal 990734b
[FLINK-34111] CR: Avoid throwing exception on invalid input
anupamaggarwal ad3ec47
[FLINK-34111] CR: Add, refactor negative tests
anupamaggarwal 04db96e
[FLINK-34111] CR: Fix unquote logic, refactor, add tests
anupamaggarwal ba9ebfa
[FLINK-34111] CR: Rearranging order of methods public to private
anupamaggarwal 80b693d
[FLINK-34111] CR: Catch only expected exceptions
anupamaggarwal 7546d9c
[FLINK-34111] CR: Exception handling, add UT
anupamaggarwal cbcb044
[FLINK-34111] CR: Add documentation for json_(un)quote to chinese doc
anupamaggarwal 37fa2e7
[FLINK-34111] CR: Update documentation
anupamaggarwal 570d28f
Merge remote-tracking branch 'oss1/master' into 34111-jsonquote_unquote
anupamaggarwal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I forgot to mention: also need to update chinese doc.
It's ok to put there english version of description however it's better to keep them synced
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
We can also create a Jira with a special tag to document gaps in the Chinese documentation: https://flink.apache.org/how-to-contribute/contribute-documentation/#chinese-documentation-translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created JIRA https://issues.apache.org/jira/browse/FLINK-35800 (and added a comment to original JIRA https://issues.apache.org/jira/browse/FLINK-34111)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creation of jira
I would still vote for having filled chinese doc with english description which then could be translated within the jira issue you've created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure @snuyanzin, fixed in cbcb044