Skip to content

Conversation

@showuon
Copy link
Member

@showuon showuon commented Jun 21, 2024

What is the purpose of the change

  1. Add the missing output method in ProcessWindowFunction#Context interface in the doc.
  2. Fix typo in Chinese doc.

Brief change log

  1. Add the missing output method in ProcessWindowFunction#Context interface in the doc.
  2. Fix typo in Chinese doc.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable)

@showuon showuon changed the title [hotfix][docs] add missing output method in Context interface [hotfix][docs] add missing output method in Context interface in the doc Jun 21, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 21, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM % the commit message should be prefixed with [hotfix][docs] like the PR title.

@showuon showuon force-pushed the ContextInterface branch from d9fe71b to 58b57ad Compare June 25, 2024 23:47
@showuon
Copy link
Member Author

showuon commented Jun 25, 2024

the commit message should be prefixed with [hotfix][docs] like the PR title.

Done. Thanks.

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, merging...

@reswqa reswqa merged commit cf0ba26 into apache:master Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants