[1.20][FLINK-35699][k8s] Fix shading Jackson through fabric8#24980
Merged
gyfora merged 1 commit intoapache:release-1.20from Jun 28, 2024
Merged
[1.20][FLINK-35699][k8s] Fix shading Jackson through fabric8#24980gyfora merged 1 commit intoapache:release-1.20from
gyfora merged 1 commit intoapache:release-1.20from
Conversation
Collaborator
31b89a3 to
07f54be
Compare
Contributor
Author
|
@flinkbot run azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The
flink-kubernetesartifact shades Jackson classes coming through fabric8, but since Jackson 2.15, Jackson is a multi-release JAR, which requires some additional relocations for correct shading.What Jackson does itself can be checked here.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
To verify, I pasted a comparison of the content of the JAR before and after the change below.
JAR content before change:
JAR content after change:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation