Skip to content

Conversation

@hackergin
Copy link
Contributor

@hackergin hackergin commented Jul 1, 2024

BP 1.20 for #25002

What is the purpose of the change

Currently, in continuous mode, the checkpoint interval is set based on freshness by default. However, if the user explicitly sets a checkpoint interval, we should follow the user's setting.

Brief change log

  • Fix periodic refresh job naming.
  • Do not override the user-defined checkpoint interval in continuous mode

Verifying this change

  • Add test testCreateMaterializedTableInContinuousModeWithCustomCheckpointInterval in MaterializedTableStatementITCase to verify that we don't over write the user custom checkpoint interval.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 1, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@lsyldliu lsyldliu merged commit d147bbf into apache:release-1.20 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants