Skip to content

Conversation

@dylanhz
Copy link
Contributor

@dylanhz dylanhz commented Aug 6, 2024

What is the purpose of the change

Add the built-in function STARTSWITH & ENDSWITH.
Examples:

> SELECT STARTSWITH('SparkSQL', 'Spark');
 TRUE
> SELECT STARTSWITH('SparkSQL', 'spark');
 FALSE

> SELECT ENDSWITH('SparkSQL', 'SQL');
 TRUE
> SELECT ENDSWITH('SparkSQL', 'sql');
 FALSE

Brief change log

FLINK-35964
FLINK-35965

Verifying this change

StringFunctionsITCase#startsWithTestCases
StringFunctionsITCase#endsWithTestCases

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 6, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dylanhz dylanhz changed the title [FLINK-35964][table] Add the built-in function STARTSWITH [FLINK-35964][table] Add the built-in function STARTSWITH & ENDSWITH Aug 21, 2024
Copy link
Contributor

@lincoln-lil lincoln-lil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments for the 1st commit.

@dylanhz
Copy link
Contributor Author

dylanhz commented Aug 26, 2024

@flinkbot run azure

1 similar comment
@lincoln-lil
Copy link
Contributor

@flinkbot run azure

@lincoln-lil
Copy link
Contributor

The failed case LeftOuterJoinTaskTest#testCancelLeftOuterJoinTaskWhileBuilding in core moulde looks weird...

Copy link
Contributor

@lincoln-lil lincoln-lil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylanhz thanks for your updates! LGTM

@lincoln-lil lincoln-lil merged commit 5bbdbb2 into apache:master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants