[FLINK-36126] Qualification of current catalog and current database should happen during execution, not parsing#25230
Merged
Merged
Conversation
…hould happen during execution, not parsing
Collaborator
snuyanzin
commented
Aug 21, 2024
| import java.util.List; | ||
| import java.util.Objects; | ||
|
|
||
| /** Abstract class for SHOW sql call. */ |
Contributor
Author
There was a problem hiding this comment.
looks like was missed in prev PR and somehow checkstyle didn't detect it...
snuyanzin
commented
Aug 21, 2024
Comment on lines
74
to
+76
| T sqlShowCall, | ||
| @Nullable String catalogName, | ||
| @Nullable String databaseName, |
Contributor
Author
There was a problem hiding this comment.
just making the order same as for getOperation
twalthr
reviewed
Aug 21, 2024
twalthr
approved these changes
Aug 21, 2024
twalthr
left a comment
twalthr
left a comment
Contributor
There was a problem hiding this comment.
Thanks for quick update!
Contributor
Author
|
@flinkbot run azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The behavior was changed in FLINK-36085 while refactoring
this PR makes the behavior as before and adds some tests for it
Also adds some missing javadocs and getters
Verifying this change
SqlShowToOperationConverterTest.java
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation