Skip to content

[FLINK-4241] [table] Cryptic expression parser exceptions#2529

Closed
twalthr wants to merge 1 commit into
apache:masterfrom
twalthr:FLINK-4241
Closed

[FLINK-4241] [table] Cryptic expression parser exceptions#2529
twalthr wants to merge 1 commit into
apache:masterfrom
twalthr:FLINK-4241

Conversation

@twalthr
Copy link
Copy Markdown
Contributor

@twalthr twalthr commented Sep 21, 2016

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

This PR improves the error message of the ExpressionParser. I tried my best but it is not easy to improve the message as we are using RegexParsers.

@fhueske
Copy link
Copy Markdown
Contributor

fhueske commented Sep 23, 2016

+1 to merge

@asfgit asfgit closed this in ef15984 Sep 26, 2016
liuyuzhong pushed a commit to liuyuzhong/flink that referenced this pull request Dec 5, 2016
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants