Skip to content

Conversation

@ztison
Copy link
Contributor

@ztison ztison commented Sep 9, 2024

What is the purpose of the change

This PR aims to unify the logic of handling state transitions and timeouts for the WaitingForResources and Executing states. To achieve that, we integrate the existing component StateTransitionManager into the WaitingForResources state.

Brief change log

  • The factory StateTransitionManager.Factory was removed.
  • The AdaptiveScheduler component is now responsible for creating a correctly configured StateTransitionManager instance for a specific state.
  • The WaitingForResources state integrates the StateTransitionManager.

Verifying this change

This change is already covered by the existing tests, such as WaitingForResourcesTest, DefaultStateTransitionManagerTest, AdaptiveSchedulerTest and AdaptiveSchedulerSimpleITCase.

Some existing tests from the class WaitingForResourcesTest were removed because they would duplicate logic now covered by the DefaultStateTransitionManagerTest class.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 9, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @ztison . Nothing else to add from my side (for more context: we did a few iterations over the code in a private fork already).

@XComp XComp merged commit 1f303a2 into apache:master Sep 10, 2024
@XComp XComp deleted the flink-36012 branch September 10, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants