Skip to content

[FLINK-36424][yarn] Update deprecated YARN RM/NM callback handlers in YarnResourceManagerDriver#25453

Merged
ferenc-csaky merged 1 commit intoapache:masterfrom
ferenc-csaky:FLINK-36424
Oct 11, 2024
Merged

[FLINK-36424][yarn] Update deprecated YARN RM/NM callback handlers in YarnResourceManagerDriver#25453
ferenc-csaky merged 1 commit intoapache:masterfrom
ferenc-csaky:FLINK-36424

Conversation

@ferenc-csaky
Copy link
Contributor

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

  • Create AMRMCallbackHandler that extends AMRMClientAsync.AbstractCallbackHandler, keeping the already existing logic from YarnContainerEventHandler.
  • Create NMCallbackHandler that extends NMClientAsync.AbstractCallbackHandler, keeping the already existing logic from YarnContainerEventHandler.
  • Adapt the related code to handle the new separate classes.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 4, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@mateczagany mateczagany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked into the YARN client code deeper, and this change should not affect the runtime behaviour. Moving away from deprecated interfaces/classes is always nice.

@ferenc-csaky
Copy link
Contributor Author

Thanks @mateczagany, if no objections until then, I will merge this around Friday EOD (CEST).

@ferenc-csaky ferenc-csaky merged commit 4b231a9 into apache:master Oct 11, 2024
@ferenc-csaky ferenc-csaky deleted the FLINK-36424 branch October 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants