[BP-1.18][FLINK-36421] [fs] [checkpoint] Sync outputStream before returning handle in FsCheckpointStreamFactory #25479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le in FsCheckpointStreamFactory Make sure the returned handle points to a file that is safely persisted to disk. Signed-off-by: Marc Aurel Fritz <marc-aurel.fritz@pm.me>
Collaborator
Zakelly
changed the title
Zakelly
approved these changes
Oct 10, 2024
Contributor
|
@flinkbot run azure |
Contributor
|
Contributor
|
@flinkbot run azure |
Contributor
|
I guess there is something wrong with CI infra for 1.18. Any thoughts? @JingGe |
Contributor
|
I would vote on merging since it's trivial change and all other branches tests are passing. |
gaborgsomogyi
approved these changes
Oct 14, 2024
Contributor
|
Will merge this without CI green .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of FLINK-36421 for 1.18
Cherry-pick of commit dfb9bfe from original PR #25468