Skip to content

Conversation

@jbalchan
Copy link
Contributor

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-36481 Remove deprecated methods TableDescriptor.forManaged

Brief change log

Remove deprecated methods

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 15, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xuyangzhong
Copy link
Contributor

Hi, @jbalchan can you take a look at the ci failure?

@jbalchan jbalchan force-pushed the FLINK-36481-Remove-deprecated-method-TableDescriptor-forManaged branch from 04081b3 to 1131652 Compare January 2, 2025 17:18
@xuyangzhong
Copy link
Contributor

@jbalchan You only removed the method TableDescriptor#forManaged without adapting all the code that uses that method.

@xuyangzhong
Copy link
Contributor

Since the removal work for managed table is too big, I have created a new pr #25910 for that and add you as a co-author there.

@jbalchan
Copy link
Contributor Author

Thankyou @xuyangzhong. Closing this PR since this is no longer useful.

@jbalchan jbalchan closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants