Skip to content

[FLINK-4573] Fix potential resource leak due to unclosed RandomAccess… #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lw-lin wants to merge 2 commits into from
Closed

[FLINK-4573] Fix potential resource leak due to unclosed RandomAccess… #2556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec0dfa
[FLINK-4573] Fix potential resource leak due to unclosed RandomAccess…
lw-lin Sep 27, 2016
6125096
Address comments
lw-lin Sep 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,15 @@ public void onSuccess(Object filePathOption) throws Throwable {
LOG.error("Displaying TaskManager log failed.", e);
return;
}
long fileLength = raf.length();
long fileLength;
try {
fileLength = raf.length();
} catch (IOException ioe) {
display(ctx, request, "Displaying TaskManager log failed.");
LOG.error("Displaying TaskManager log failed.", ioe);
raf.close();
throw ioe;
}
final FileChannel fc = raf.getChannel();

HttpResponse response = new DefaultHttpResponse(HTTP_1_1, OK);
Expand Down