[FLINK-36492][TABLE API] Remove all deprecated methods in ListView #25565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tinaselenge
force-pushed
the
FLINK-36492
branch
from
ec403ec to
8927657
Compare
Contributor
Author
|
@flinkbot run azure |
tomncooper
approved these changes
Nov 11, 2024
Contributor
tomncooper
left a comment
tomncooper
left a comment
There was a problem hiding this comment.
LGTM, if you rebase on master you should get the fixes for the wikiedits test failures.
tinaselenge
force-pushed
the
FLINK-36492
branch
from
8927657 to
9ea6306
Compare
SamBarker
approved these changes
Nov 11, 2024
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/ListView.java
Show resolved
Hide resolved
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
tinaselenge
force-pushed
the
FLINK-36492
branch
2 times, most recently
from
cbffeba to
b84c23a
Compare
tinaselenge
force-pushed
the
FLINK-36492
branch
from
b84c23a to
8a06b99
Compare
Contributor
|
Hi, @tinaselenge can you take a look at the compile failure in ci? |
tinaselenge
force-pushed
the
FLINK-36492
branch
from
8a06b99 to
8c16bf1
Compare
Contributor
Author
|
@xuyangzhong thanks. The ci failure is fixed. |
xuyangzhong
reviewed
Jan 7, 2025
Contributor
xuyangzhong
left a comment
xuyangzhong
left a comment
There was a problem hiding this comment.
Thanks for driving this! I just left some comments.
...le-planner/src/main/scala/org/apache/flink/table/planner/typeutils/LegacyDataViewUtils.scala
Outdated
Show resolved
Hide resolved
xuyangzhong
approved these changes
Jan 14, 2025
Contributor
xuyangzhong
left a comment
xuyangzhong
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating.
lsyldliu
reviewed
Jan 14, 2025
Contributor
lsyldliu
left a comment
lsyldliu
left a comment
There was a problem hiding this comment.
@tinaselenge Thanks for your contribution, I left a comment.
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/dataview/ListView.java
Show resolved
Hide resolved
ryanvanhuuksloot
pushed a commit
to ryanvanhuuksloot/flink
that referenced
this pull request
Feb 19, 2025
…apache#25565) Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
Au-Miner
pushed a commit
to Au-Miner/flink
that referenced
this pull request
Feb 23, 2025
…apache#25565) Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is a subtask of [FLINK-36476](https://issues.apache.org/jira/browse/FLINK-36476) Remove all deprecated methods under public APIs in table modules
Brief change log
Remove deprecated method
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation