[FLINK-36662][table-planner] Port CALCITE-6317 to fix the incorrectly constant pullup when group keys in aggregate are NULL#25612
Merged
lincoln-lil merged 2 commits intoapache:masterfrom Nov 7, 2024
Conversation
… constant pullup when group keys in aggregate are NULL
Collaborator
snuyanzin
reviewed
Nov 5, 2024
| /** | ||
| * Utility to infer Predicates that are applicable above a RelNode. | ||
| * | ||
| * <p>The class was copied over based on calcite-1.32.0 and added the bugfix of CALCITE-6317. |
Contributor
There was a problem hiding this comment.
Can you please mark the changed lines with
// ------ FLINK MODIFICATION BEGIN
...
// ------ FLINK MODIFICATION END
and put numbers of lines in class comment as it is done for other Calcite's classes
it will significantly help during upgrade (before we reach 1.37)
Contributor
Author
There was a problem hiding this comment.
@snuyanzin thank you for reviewing this so quickly! (My original plan was to use the night hours (utc+8) to do a full assessment of the impact of the existing tests)
I've now added a description of the scope for the changes.
snuyanzin
approved these changes
Nov 7, 2024
Contributor
snuyanzin
left a comment
There was a problem hiding this comment.
LGTM
thanks for addressing feedback
Contributor
Author
@snuyanzin Thank you! Merging... |
xaniasd
pushed a commit
to xaniasd/flink
that referenced
this pull request
Jan 13, 2025
… constant pullup when group keys in aggregate are NULL This closes apache#25612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pr port the bugfix of CALCITE-6317 to fix the incorrectly constant pullup when group keys in aggregate are NULL
Before upgraded corresponding calcite version(1.37), we can have the fix that copy the related
RelMdPredicatesto flink and remove it after calcite version upgrading done.Brief change log
Copy the
RelMdPredicatesbased on 1.32.0 and add the fix of CALCITE-6317Verifying this change
Add new case for
GroupingSetsTestDoes this pull request potentially affect one of the following parts:
Documentation