Skip to content

Conversation

@liuyongvs
Copy link
Contributor

What is the purpose of the change

A bit reasoning for the change
high calcite version has fixed, current calcite version is 1.34

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 26, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor

This is just class removal, I don't think we need to split it in several PRs
can you combine this and #25690 into one?

@liuyongvs
Copy link
Contributor Author

hi @snuyanzin , may not! every rule whether can be removed should be checked.
for example FlinkPruneEmptyRules this rule will cause some test failed because plan changed.
and i also check other rule copy from calcite in flink can not removed.

@davidradl
Copy link
Contributor

Reviewed by Chi on 28/11/24 business as usual progressing with committer involved.

@liuyongvs
Copy link
Contributor Author

hi @snuyanzin will you look again?

@snuyanzin snuyanzin merged commit 266f3a5 into apache:master Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants