Skip to content

[FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join#25729

Closed
reswqa wants to merge 4 commits intoapache:masterfrom
reswqa:lookup-open-pr-new
Closed

[FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join#25729
reswqa wants to merge 4 commits intoapache:masterfrom
reswqa:lookup-open-pr-new

Conversation

@reswqa
Copy link
Member

@reswqa reswqa commented Dec 3, 2024

What is the purpose of the change

Implements FLIP-462: Support Custom Data Distribution for Input Stream of Lookup Join.

Brief change log

  • Expose taskinfo in FunctionContext
  • Introduce SupportsLookupCustomShuffle interface
  • Shuffle input stream of lookup join based on LOOKUP hint

Verifying this change

UT & IT

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? later PR

@reswqa reswqa changed the title [WIP][FLINK-35652] Shuffle input stream of lookup join based on LOOKUP hint [WIP][FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join Dec 3, 2024
@reswqa reswqa marked this pull request as ready for review December 3, 2024 10:18
@flinkbot
Copy link
Collaborator

flinkbot commented Dec 3, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa reswqa force-pushed the lookup-open-pr-new branch from fac24ab to f82bde7 Compare December 4, 2024 02:55
@reswqa reswqa changed the title [WIP][FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join [FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join Dec 4, 2024
@reswqa
Copy link
Member Author

reswqa commented Dec 4, 2024

@flinkbot run azure

Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some comments as below.

Copy link
Contributor

@hackergin hackergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reswqa Thanks for the contribution, only one minor comment.

@yunfengzhou-hub
Copy link
Contributor

Thanks for the update! LGTM.

@reswqa
Copy link
Member Author

reswqa commented Dec 9, 2024

@flinkbot run azure

Copy link
Contributor

@xuyangzhong xuyangzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is pretty good. LGTM overall.

@reswqa reswqa closed this in cfaa00e Dec 9, 2024
@reswqa
Copy link
Member Author

reswqa commented Dec 9, 2024

Thanks all for the review, merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants