[FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join#25729
Closed
reswqa wants to merge 4 commits intoapache:masterfrom
Closed
[FLINK-35652] Support Custom Data Distribution for Input Stream of Lookup Join#25729reswqa wants to merge 4 commits intoapache:masterfrom
reswqa wants to merge 4 commits intoapache:masterfrom
Conversation
Collaborator
fac24ab to
f82bde7
Compare
Member
Author
|
@flinkbot run azure |
Contributor
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the PR. Left some comments as below.
.../main/java/org/apache/flink/table/runtime/connector/source/LookupRuntimeProviderContext.java
Outdated
Show resolved
Hide resolved
...scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalLookupJoin.scala
Show resolved
Hide resolved
...nk-table-api-java/src/main/java/org/apache/flink/table/api/config/LookupJoinHintOptions.java
Show resolved
Hide resolved
hackergin
reviewed
Dec 6, 2024
...src/main/java/org/apache/flink/table/runtime/partitioner/RowDataCustomStreamPartitioner.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for the update! LGTM. |
Member
Author
|
@flinkbot run azure |
xuyangzhong
approved these changes
Dec 9, 2024
Contributor
xuyangzhong
left a comment
There was a problem hiding this comment.
This pr is pretty good. LGTM overall.
Member
Author
|
Thanks all for the review, merged into master. |
xaniasd
pushed a commit
to xaniasd/flink
that referenced
this pull request
Jan 13, 2025
…KUP hint This closes apache#25729.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Implements FLIP-462: Support Custom Data Distribution for Input Stream of Lookup Join.
Brief change log
Verifying this change
UT & IT
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation