[FLINK-36838][state] Join background threads when ForSt state backend quit#25732
Merged
Zakelly merged 2 commits intoapache:masterfrom Dec 4, 2024
Merged
[FLINK-36838][state] Join background threads when ForSt state backend quit#25732Zakelly merged 2 commits intoapache:masterfrom
Zakelly merged 2 commits intoapache:masterfrom
Conversation
Collaborator
fredia
approved these changes
Dec 4, 2024
Contributor
fredia
left a comment
There was a problem hiding this comment.
Thanks for the fix, LGTM.
This was referenced Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently there is an issue in the forst db core, where the background cannot properly quit when db close. Thus we manually join those threads in backend side. This is a temporary solution until the forst db fix the bug.
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation