Skip to content

Conversation

@JunRuiLee
Copy link
Contributor

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-36072
Optimizing the Overhead of the Network Layer in Adaptive Execution Scenarios

Brief change log

  • On the downstream side, enable a single input gate to support a single input channel consuming multiple subpartitions.
  • On the upstream side, enable sort-merge shuffle could use single partition reader to read multiple subpartitions
  • On the upstream side, enable sort-merge shuffle supports accumulating small buffers to reduce network overhead.

Verifying this change

This change added tests and can be verified such as CreditBasedPartitionRequestClientHandlerTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 4, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JunRuiLee JunRuiLee force-pushed the FLINK-36072 branch 2 times, most recently from 3dd4adb to 1cabe2f Compare December 5, 2024 06:20
@davidradl
Copy link
Contributor

Reviewed by Chi on 05/12/24 in hand

@JunRuiLee JunRuiLee force-pushed the FLINK-36072 branch 3 times, most recently from 6b8d41c to 2c77c9c Compare December 10, 2024 09:14
@JunRuiLee JunRuiLee force-pushed the FLINK-36072 branch 2 times, most recently from bb7d3fd to 6e46502 Compare December 11, 2024 12:11
@JunRuiLee
Copy link
Contributor Author

Thanks @reswqa for reviewing this PR. I have updated it accordingly and rebased it onto the master. PTAL.

@JunRuiLee
Copy link
Contributor Author

@flinkbot run azure

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@JunRuiLee JunRuiLee merged commit 2d9fb79 into apache:master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants