-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-37001][table] Remove code related to registerTableSinkInternal in tests and remove this method in TableEnvironmentInternal #25889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
245b65a to
1a84fb1
Compare
lsyldliu
reviewed
Jan 7, 2025
Contributor
lsyldliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuyangzhong Thanks for your contribution, I left some comments.
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...table-planner/src/test/scala/org/apache/flink/table/planner/utils/testTableSourceSinks.scala
Outdated
Show resolved
Hide resolved
...table-planner/src/test/scala/org/apache/flink/table/planner/utils/testTableSourceSinks.scala
Show resolved
Hide resolved
...-end-tests/flink-tpcds-test/src/main/java/org/apache/flink/table/tpcds/TpcdsTestProgram.java
Outdated
Show resolved
Hide resolved
...flink-tpcds-test/src/main/java/org/apache/flink/table/tpcds/utils/TpcdsResultComparator.java
Outdated
Show resolved
Hide resolved
1a84fb1 to
e1039a6
Compare
Contributor
Author
|
@flinkbot run azure |
2 similar comments
Contributor
Author
|
@flinkbot run azure |
Contributor
Author
|
@flinkbot run azure |
cb85051 to
1925054
Compare
… in tests and remove this method in TableEnvironmentInternal
1925054 to
6104ad9
Compare
6104ad9 to
2ebe54f
Compare
lsyldliu
approved these changes
Jan 17, 2025
Contributor
lsyldliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove all direct uses of
TableEnvironmentInternal#registerTableSinkInternalin table module.Brief change log
TableEnvironmentInternal#registerTableSinkInternalin table moduleTableEnvironmentInternal#registerTableSinkInternalVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation