Skip to content

Conversation

@xuyangzhong
Copy link
Contributor

What is the purpose of the change

Remove all direct uses of TableEnvironmentInternal#registerTableSinkInternal in table module.

Brief change log

  • Remove all direct uses of TableEnvironmentInternal#registerTableSinkInternal in table module
  • Remove the method TableEnvironmentInternal#registerTableSinkInternal

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 3, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuyangzhong Thanks for your contribution, I left some comments.

@xuyangzhong
Copy link
Contributor Author

@flinkbot run azure

2 similar comments
@xuyangzhong
Copy link
Contributor Author

@flinkbot run azure

@xuyangzhong
Copy link
Contributor Author

@flinkbot run azure

@xuyangzhong xuyangzhong force-pushed the FLINK-37001 branch 3 times, most recently from cb85051 to 1925054 Compare January 13, 2025 08:07
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsyldliu lsyldliu merged commit 6b4385e into apache:master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants