[FLINK-37006][table] Apply changes from FLINK-36277 to AdaptiveJoin #25895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lsyldliu |
Collaborator
Contributor
Author
|
also + @JunRuiLee , @zhuzhurk since you were participating in AdaptiveJoin |
Contributor
Author
|
@flinkbot run azure |
Contributor
|
Hi, @snuyanzin there has been a quick hotfix #25891 waiting anybody helps review & merge for it after #25326 being merged, and ci has passed. |
xuyangzhong
approved these changes
Jan 4, 2025
Zakelly
approved these changes
Jan 4, 2025
Contributor
Zakelly
left a comment
Zakelly
left a comment
There was a problem hiding this comment.
I also encountered the CI failure. LTGM.
snuyanzin
added a commit
to snuyanzin/flink
that referenced
this pull request
Jan 4, 2025
This closes apache#25895 -------------------- Co-authored-by: xuyang <xyzhong188@163.com>
Contributor
Author
|
Thanks everyone for taking a look @xuyangzhong thanks for pointing to that |
snuyanzin
changed the title
xaniasd
pushed a commit
to xaniasd/flink
that referenced
this pull request
Jan 13, 2025
This closes apache#25895 -------------------- Co-authored-by: xuyang <xyzhong188@163.com>
Au-Miner
pushed a commit
to Au-Miner/flink
that referenced
this pull request
Feb 23, 2025
This closes apache#25895 -------------------- Co-authored-by: xuyang <xyzhong188@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is a follow up for #25326 for
AdaptiveJoinwhich breaks master likehttps://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=64822&view=logs&j=0c940707-2659-5648-cbe6-a1ad63045f0a&t=075c2716-8010-5565-fe08-3c4bb45824a4&l=12021
The PR is going to fix that
Brief change log
plan changes
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation