Skip to content

Conversation

@codenohup
Copy link
Contributor

What is the purpose of the change

Support Event Time by Generalized Watermark in DataStream V2

Brief change log

More information see FLIP-499:
https://cwiki.apache.org/confluence/x/pQz0Ew

Verifying this change

This change added tests and can be verified as follows:

  • Add integration test cases, org.apache.flink.test.streaming.api.datastream.extension.eventtime.EventTimeExtensionITCase
  • Add unit test cases

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? I will add documentation in a future pull request.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 14, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@codenohup codenohup force-pushed the pr-event-time branch 2 times, most recently from d9d6644 to 3971cb3 Compare January 16, 2025 07:30
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, only left two minor comments.

@codenohup codenohup force-pushed the pr-event-time branch 2 times, most recently from 607bb6b to ebc4796 Compare January 16, 2025 10:07
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@reswqa reswqa merged commit 69e67fa into apache:master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants