-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-37112] Support Event Time Extension in DataStream V2 #25978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
reswqa
reviewed
Jan 14, 2025
.../org/apache/flink/datastream/impl/attribute/StreamingJobGraphGeneratorWithAttributeTest.java
Show resolved
Hide resolved
...org/apache/flink/datastream/api/extension/eventtime/strategy/EventTimeWatermarkStrategy.java
Outdated
Show resolved
Hide resolved
...he/flink/datastream/api/extension/eventtime/strategy/EventTimeWatermarkGeneratorBuilder.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/apache/flink/datastream/api/extension/eventtime/EventTimeExtension.java
Show resolved
Hide resolved
...a/org/apache/flink/datastream/api/extension/eventtime/function/EventTimeProcessFunction.java
Outdated
Show resolved
Hide resolved
...link/datastream/api/extension/eventtime/function/OneInputEventTimeStreamProcessFunction.java
Show resolved
Hide resolved
...link/datastream/api/extension/eventtime/function/OneInputEventTimeStreamProcessFunction.java
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/datastream/api/extension/eventtime/timer/EventTimeManager.java
Outdated
Show resolved
Hide resolved
reswqa
reviewed
Jan 14, 2025
...che/flink/datastream/impl/extension/eventtime/functions/ExtractEventTimeProcessFunction.java
Show resolved
Hide resolved
...che/flink/datastream/impl/extension/eventtime/functions/ExtractEventTimeProcessFunction.java
Show resolved
Hide resolved
...che/flink/datastream/impl/extension/eventtime/functions/ExtractEventTimeProcessFunction.java
Outdated
Show resolved
Hide resolved
...che/flink/datastream/impl/extension/eventtime/functions/ExtractEventTimeProcessFunction.java
Outdated
Show resolved
Hide resolved
reswqa
reviewed
Jan 15, 2025
flink-runtime/src/main/java/org/apache/flink/streaming/util/watermark/WatermarkUtils.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/apache/flink/datastream/api/extension/eventtime/EventTimeExtension.java
Show resolved
Hide resolved
...pi/src/main/java/org/apache/flink/datastream/api/extension/eventtime/EventTimeExtension.java
Show resolved
Hide resolved
...java/org/apache/flink/datastream/impl/extension/eventtime/timer/DefaultEventTimeManager.java
Outdated
Show resolved
Hide resolved
...apache/flink/test/streaming/api/datastream/extension/eventtime/EventTimeExtensionITCase.java
Outdated
Show resolved
Hide resolved
...apache/flink/test/streaming/api/datastream/extension/eventtime/EventTimeExtensionITCase.java
Show resolved
Hide resolved
d9d6644 to
3971cb3
Compare
reswqa
reviewed
Jan 16, 2025
Member
reswqa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, only left two minor comments.
...pi/src/main/java/org/apache/flink/datastream/api/extension/eventtime/EventTimeExtension.java
Show resolved
Hide resolved
...org/apache/flink/datastream/api/extension/eventtime/strategy/EventTimeWatermarkStrategy.java
Outdated
Show resolved
Hide resolved
607bb6b to
ebc4796
Compare
reswqa
approved these changes
Jan 16, 2025
Member
reswqa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
…imeWatermarkGeneratorBuilder for DataStream V2
…s in operator for DataStream V2
… EventTimeProcessFunction for DataStream V2
ebc4796 to
9855bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support Event Time by Generalized Watermark in DataStream V2
Brief change log
More information see FLIP-499:
https://cwiki.apache.org/confluence/x/pQz0Ew
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation