Skip to content

[FLINK-37140][runtime] Create async timer service when restore async operator#25993

Merged
fredia merged 3 commits intoapache:masterfrom
fredia:restoreTimer
Jan 17, 2025
Merged

[FLINK-37140][runtime] Create async timer service when restore async operator#25993
fredia merged 3 commits intoapache:masterfrom
fredia:restoreTimer

Conversation

@fredia
Copy link
Copy Markdown
Contributor

@fredia fredia commented Jan 16, 2025

What is the purpose of the change

Create an async timer service when restoring async operator.

Brief change log

  • Add restoreTimeService for InternalTimeServiceManagerImpl.
  • Allow setup AEC after InternalTimerServiceAsyncImpl initialization.

Verifying this change

This change added tests and can be verified as follows:

  • InternalTimerServiceAsyncImplTest#testSnapshotAndRestore

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@fredia fredia marked this pull request as ready for review January 16, 2025 02:35
@fredia fredia requested a review from Zakelly January 16, 2025 02:49
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jan 16, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall looks good

@fredia
Copy link
Copy Markdown
Contributor Author

fredia commented Jan 17, 2025

@flinkbot run azure

Copy link
Copy Markdown
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fredia
Copy link
Copy Markdown
Contributor Author

fredia commented Jan 17, 2025

Thanks for the review, CI(https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=65416&view=results) is green so merge.

@fredia fredia merged commit 33de4ea into apache:master Jan 17, 2025
ryanvanhuuksloot pushed a commit to ryanvanhuuksloot/flink that referenced this pull request Feb 19, 2025
Au-Miner pushed a commit to Au-Miner/flink that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants