Skip to content

Conversation

@AlexYinHan
Copy link
Contributor

What is the purpose of the change

This PR implements fast snapshot/restore for ForSt. Specifically, it implements different strategies for ForStStateDataTransfer, so that ForSt can reuse the checkpoint files as much as possible and thus reduce the cost of file copying.

Brief change log

  • Enhance the FileMappingManager so it can track the ownership of files
  • Implement different strategies for ForStStateDataTransfer

Verifying this change

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not applicable)

@AlexYinHan
Copy link
Contributor Author

@flinkbot run azure

@AlexYinHan AlexYinHan force-pushed the yh/fast_cp_on_fast_rescale_strategy branch from 37d4800 to 0d8b60d Compare January 20, 2025 04:44
@Zakelly
Copy link
Contributor

Zakelly commented Jan 20, 2025

@flinkbot run azure

@AlexYinHan AlexYinHan force-pushed the yh/fast_cp_on_fast_rescale_strategy branch from 0d8b60d to fc26f6c Compare January 20, 2025 05:32
@Zakelly
Copy link
Contributor

Zakelly commented Jan 20, 2025

@flinkbot run azure

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 20, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Zakelly
Copy link
Contributor

Zakelly commented Jan 20, 2025

The review goes in #25924 . This is another trigger for CI.

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zakelly
Copy link
Contributor

Zakelly commented Jan 20, 2025

CI passed except for the flink-table. It is an unrelated issue which has been addressed by #26018. To not blocking the feature freeze of 2.0, I'd merge this instead of rebasing and running another CI.

@Zakelly Zakelly merged commit dccb782 into apache:master Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants